Add Imp tests to cover more cases of active/inactive committee #5466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlostome
force-pushed
the
carlos/add-conf-test
branch
6 times, most recently
from
9ac443a to
5ee671e
Compare
carlostome
changed the title
carlostome
force-pushed
the
carlos/add-conf-test
branch
from
5ee671e to
1d82e40
Compare
Soupstraw
reviewed
Dec 8, 2025
Comment on lines
154
to
177
| coldCommitteeActive <- KeyHashObj <$> freshKeyHash | ||
| coldCommitteeInactive <- KeyHashObj <$> freshKeyHash | ||
| startingEpoch <- getsNES nesELL | ||
| maxTermLength <- getsPParams ppCommitteeMaxTermLengthL | ||
| (drep, _, _) <- setupSingleDRep 1_000_000_000 | ||
| (spo, _, _) <- setupPoolWithStake $ Coin 1_000_000_000 | ||
| let | ||
| committeeMap = | ||
| [ (coldCommitteeActive, addEpochInterval startingEpoch maxTermLength) | ||
| , (coldCommitteeInactive, addEpochInterval startingEpoch $ EpochInterval 5) | ||
| ] | ||
| initialCommittee <- getCommitteeMembers | ||
| committeeActionId <- | ||
| impAnn "Submit committee update" | ||
| . submitGovAction | ||
| $ UpdateCommittee | ||
| SNothing | ||
| initialCommittee | ||
| committeeMap | ||
| (1 %! 1) | ||
| submitYesVote_ (DRepVoter drep) committeeActionId | ||
| submitYesVote_ (StakePoolVoter spo) committeeActionId | ||
| passNEpochs 5 | ||
| getCommitteeMembers `shouldReturn` Map.keysSet committeeMap |
Contributor
There was a problem hiding this comment.
I think this part should be moved to its own function setupActiveAndInactiveCCMembers and then we can reuse it in the other tests.
Contributor
There was a problem hiding this comment.
Maybe make it parametrized on the threshold as well
carlostome
force-pushed
the
carlos/add-conf-test
branch
2 times, most recently
from
48c98f2 to
2ed7407
Compare
carlostome
force-pushed
the
carlos/add-conf-test
branch
from
2ed7407 to
886ac62
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Committee proposals pass"to its proper placeRelated to #5418
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).